FileInput - Add 100% width style (HDS-5106)
#3318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase example for testing purposes, add changeset
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
KristinLBradley
commented
Oct 21, 2025
| @use "../../mixins/button" as *; | ||
|
|
||
| .hds-form-file-input { | ||
| width: 100%; // we want to prevent the input from overflowing its container |
Contributor
Author
There was a problem hiding this comment.
Adding max-width made no difference, so I left it out
Updated FileInput to have a width of 100% for consistency.
KristinLBradley
commented
Oct 22, 2025
| <ShwTextH3>States</ShwTextH3> | ||
|
|
||
| <ShwFlex @gap="2rem" as |SF|> | ||
| <ShwGrid @columns={{4}} @gap="2rem" as |SG|> |
Contributor
Author
There was a problem hiding this comment.
Changing this to a Grid allowed the style update to be tested & seen in the example when the browser screen width was reduced. (Let me know if you think it would be better to add a new example.)
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Contributor
Author
There was a problem hiding this comment.
@didoo I changed this part back and added a new "Containers" sub-section.
didoo
reviewed
Oct 22, 2025
Contributor
didoo
left a comment
didoo
left a comment
There was a problem hiding this comment.
left a couple of minor comments
| <ShwTextH3>States</ShwTextH3> | ||
|
|
||
| <ShwFlex @gap="2rem" as |SF|> | ||
| <ShwGrid @columns={{4}} @gap="2rem" as |SG|> |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Co-authored-by: Cristiano Rastelli <[email protected]>
didoo
previously approved these changes
Oct 22, 2025
showcase/app/components/page-components/form/file-input/sub-sections/containers.gts
Outdated
Show resolved
Hide resolved
Merged
aklkv
pushed a commit
that referenced
this pull request
Oct 26, 2025
Co-authored-by: Cristiano Rastelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 Summary
If merged, this PR adds
width: 100%to theFileInputwhich prevents it from overflowing its container when space is limited in layouts (browsers will automatically truncate text) and making it consistent with the styling of other component input widths.Preview: https://hds-showcase-git-hds-5106-file-input-width-update-hashicorp.vercel.app/components/form/file-input
📸 Screenshots
🔗 External links
👀 Component checklist
💬 Please consider using conventional comments when reviewing this PR.
📋 PCI review checklist
Examples of changes to controls include access controls, encryption, logging, etc.
Examples include changes to operating systems, ports, protocols, services, cryptography-related components, PII processing code, etc.