custom VNC password changes #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anurag5sh
reviewed
Apr 22, 2025
anurag5sh
previously approved these changes
Apr 22, 2025
kp2099
reviewed
Apr 22, 2025
builder/qemu/step_configure_vnc.go
Outdated
| @@ -28,7 +28,21 @@ type stepConfigureVNC struct { | |||
| l *net.Listener | |||
| } | |||
|
|
|||
| func VNCPassword() string { | |||
| type vncpwd struct{} | |||
There was a problem hiding this comment.
Suggested change
| type vncpwd struct{} | |
| type vncPassword struct{} |
builder/qemu/step_configure_vnc.go
Outdated
| func VNCPassword() string { | ||
| type vncpwd struct{} | ||
|
|
||
| func (p *vncpwd) VNCPassword(c *Config) (string, error) { |
There was a problem hiding this comment.
Suggested change
| func (p *vncpwd) VNCPassword(c *Config) (string, error) { | |
| func (p *vncpwd) getVNCPassword(c *Config) (string, error) { |
There was a problem hiding this comment.
Probably we can rename the method to this. Or any other better naming convention you would like
kp2099
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Ability to set the custom VNC password. So the user can set their own VNC password required to connect to VM through VNC. This way do not have to go through the debug log to look at the set password.
Added the unit test cases and tested through the sample packer templates.
Closes #186