Skip to content

Conversation

jbardin
Copy link
Member

@jbardin jbardin commented Aug 12, 2025

This updates the go-plugin package to the latest release. Changes include

  • Go-plugin also now emits stack traces at an Error level rather than Debug.
  • Go-plugin will avoid the overhead of processing logs if logging is not enabled.

That second optimization is not something that Terraform can currently make use of though, because for a better user experience we still need to monitor the provider logs for stack traces. So even though neither of these changes directly affect Terraform, I'm making sure the upgrade is done now in isolation because the combination of those changes requires fixes in core to accommodate, and we can merge them now rather than surprising a future maintainer.

@jbardin jbardin requested a review from a team as a code owner August 12, 2025 15:37
@jbardin jbardin added the no-changelog-needed Add this to your PR if the change does not require a changelog entry label Aug 12, 2025
Copy link
Member

@SarahFrench SarahFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you missed it, this PR needs make syncdeps to be run. I imagine the changes to the backends' go.mod files would not require provider teams to run tests though!

@jbardin jbardin requested review from a team as code owners August 12, 2025 16:33
Go-plugin now reports stack traces via and Error log level, so we need
to update the logger to watch that level instead. We also must
explicitly enable logging for the plugin, because go-plugin will
otherwise no send any logs at all.
@jbardin jbardin force-pushed the jbardin/update-go-plugin branch from 5359d5a to 7ed24d2 Compare August 12, 2025 18:05
@jbardin jbardin requested a review from a team August 13, 2025 12:34
@jbardin jbardin merged commit eee744c into main Aug 13, 2025
7 checks passed
@jbardin jbardin deleted the jbardin/update-go-plugin branch August 13, 2025 12:52
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no-changelog-needed Add this to your PR if the change does not require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants