Optimize updateOrConcatWithKey #435
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whee! This shrinking stuff is cool. I remain concerned about its implications for the non-moving garbage collector. That adds some code to each shrink for ... some sort of fancy footwork. @bgamari, could you advise on performance implications? |
This was referenced Apr 25, 2022
Undefineds might be useful for debugging
This reverts commit 3315dba.
sjakobi
force-pushed
the
sjakobi/403-updateOrConcatWithKey
branch
from
fcab796 to
7617553
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #403.
TODO: