Refactor and slightly optimize two
#524
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces the core size for the inner loop of two by 10 terms.
* Use the "shifted hash" approach. * Create a variant `two'` that can be used to address #468.
Just to be safe.
sjakobi
force-pushed
the
sjakobi/two-opt
branch
from
8b58987 to
be9c660
Compare
sjakobi
force-pushed
the
sjakobi/two-opt
branch
from
be9c660 to
bd0b04f
Compare
|
After some additional benchmark runs und more staring at the Core diffs, I've become less convinced that this is clear-cut improvement. While I'm fairly convinced that the inner loop of On the other hand, it may matter that the allocation of the new Leaf is now inlined into the calling function. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Extracted from #521)
This speeds up
fromListabout 1–2% and prepares the ground for #520.