Skip to content

Conversation

@GulinSS
Copy link
Contributor

@GulinSS GulinSS commented Jan 3, 2025

See details: https://gitlab.haskell.org/ghc/ghc/-/issues/24603#note_565835

The patch adds support Aarch64 builds at Windows platform.

Template Α: This PR modifies behaviour or interface

Include the following checklist in your PR:


Asking for an exemption for tests.
I am not sure about QA notes. Should I add a link to the compiler which can be used to test it? Temporal link is here.

@fgaz
Copy link
Member

fgaz commented Jan 5, 2025

Looks good, but please use template A and write a changelog entry, since this change is relevant to users

@GulinSS GulinSS changed the title Add support for Windows ARM Add support for Windows Aarch64 Jan 5, 2025
@GulinSS GulinSS force-pushed the wip/T24603 branch 2 times, most recently from 0829693 to 0a2e5ac Compare January 5, 2025 11:06
@GulinSS GulinSS force-pushed the wip/T24603 branch 2 times, most recently from b406f05 to 7f7451f Compare January 10, 2025 09:23
@GulinSS
Copy link
Contributor Author

GulinSS commented Jan 10, 2025

Forgot one item with c_GetModuleFileName for paths generation.


Hm... What is wrong with the check?

@fgaz
Copy link
Member

fgaz commented Jan 10, 2025

PathsModule is autogenerated, you have to modify Z.hs and run cabal run gen-paths-module iirc

@GulinSS
Copy link
Contributor Author

GulinSS commented Jan 11, 2025

@fgaz thanks for the pointing!

I was needed to manually remove file pathes defined by TEMPLATE_MACROS and TEMPLATE_PATHS at Makefile and then just run

make templates

@Bodigrim Bodigrim added the merge me Tell Mergify Bot to merge label Jan 13, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Jan 13, 2025
@mergify mergify bot merged commit 4b03f13 into haskell:master Jan 15, 2025
46 checks passed
@GulinSS GulinSS deleted the wip/T24603 branch April 10, 2025 20:42
@ffaf1 ffaf1 mentioned this pull request Jul 6, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge platform: windows ready and waiting Mergify is waiting out the cooldown period

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants