-
Notifications
You must be signed in to change notification settings - Fork 723
Backport #10719: Follow HLint suggestion: use fewer imports #10733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
(cherry picked from commit c7f3def)
- Use fewer imports with CPP in Compat.Time - Use fewer imports in IntegrationTests2 - Use fewer imports in Distribution.Client.ProjectPlanning - Use fewer imports in Distribution.Client.Config - Use fewer imports in Distribution.Client.NixStyleOptions - Use fewer imports in Internal.TempFile - Use fewer imports in Distribution.Client.Store - Use fewer imports in Distribution.Client.SetupWrapper - Use fewer imports in Disribution.Simple.GHC - Use fewer imports in NeedleHaystack - Remove unused -XCPP from Client.ProjectPlanning - Enable hlint suggestion "Use fewer imports" - Ignore custom setup test files from Idris and Doctest (cherry picked from commit 217f08a) # Conflicts: # .hlint.yaml # cabal-install/tests/IntegrationTests2.hs # cabal-testsuite/src/Test/Cabal/NeedleHaystack.hs
(cherry picked from commit d165dfd) # Conflicts: # .hlint.yaml
|
Cherry-pick of 217f08a has failed: Cherry-pick of d165dfd has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
@Kleidukos: do we still want to merge this one or is it subsumed by something else? |
|
At this point, just before the 3.14.2 release, I'd rather not backport a big but non-critical PR, so let's wait until after the release or let's drop it. |
|
@Mikolaj I don't have a strong opinion, but one argument that was used in the past for PRs with many small changes like this one is that not backporting them will create more conflicts when backporting other PRs... |
|
That's a valid point and we still have 4 more backports to create, so a conflict can still emerge. On a second look, this PR is very safe, so let me backport it. |
|
@mergify backport 3.14 |
✅ Backports have been created
|
|
uhoh, thinko |
See #9110. The HLint "use fewer imports" suggestion was too much trouble to enable before most of the base CPP conditionals, "base 4.13 and older", were removed in #10092.
We're using fourmolu but this doesn't merge multiple imports from the same module.
The removal of
MIN_VERSION_base(4,11,0)is permitted by #8998 (comment) and #8998 (comment).Two files used for our tests taken from other projects are now ignored for linting, in
.hlint.yaml:The first of these,
CabalDoctestSetup.hs, was mentioned by @Kleidukos in #8998 (comment).Template B: This PR does not modify behaviour or interface
E.g. the PR only touches documentation or tests, does refactorings, etc.
Include the following checklist in your PR:
This is an automatic backport of pull request #10719 done by [Mergify](https://mergify.com).