Skip to content

Conversation

@ffaf1
Copy link
Collaborator

@ffaf1 ffaf1 commented Jul 2, 2025

Include the following checklist in your PR:

  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

Note: #10915 should be fixed by --with-repl.

@ffaf1 ffaf1 force-pushed the 3.16-changelogs branch 2 times, most recently from f3ac4bc to 94018fa Compare July 2, 2025 19:13
geekosaur
geekosaur previously approved these changes Jul 2, 2025
@geekosaur geekosaur self-requested a review July 2, 2025 22:48
@geekosaur geekosaur dismissed their stale review July 2, 2025 22:49

I should go through again and catch typos and grammar issues

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't get to the meat yet

@ffaf1 ffaf1 force-pushed the 3.16-changelogs branch 2 times, most recently from bc1e843 to b37cd10 Compare July 3, 2025 07:12
@ffaf1 ffaf1 force-pushed the 3.16-changelogs branch from d61f57a to 30f6657 Compare July 3, 2025 19:25
@ffaf1 ffaf1 force-pushed the 3.16-changelogs branch from 30f6657 to 2bb7f5f Compare July 4, 2025 06:55
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Jul 5, 2025

@ulysses4ever Once you are fine with these, I can put the merge me label.

@ulysses4ever
Copy link
Collaborator

@ffaf1 yeah, sorry, I'm swamped by the holidays in the US. I'll try to attend to it by Monday.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baby steps...

@ffaf1 ffaf1 force-pushed the 3.16-changelogs branch from 2bb7f5f to 4844a0d Compare July 6, 2025 07:31
@ffaf1 ffaf1 mentioned this pull request Jul 6, 2025
5 tasks
@ffaf1 ffaf1 force-pushed the 3.16-changelogs branch from 4844a0d to 73f026f Compare July 6, 2025 15:30
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's all I have for now. I want to do only one more thing: request copilot to review this PR (as an experiment), but that's after you look through my comments.

ffaf1 added 2 commits July 8, 2025 17:08
* Integrate Brandon’s suggestions.
* Integrate Brandon’s suggestions /II.
* Integrate Bodigrim’s suggestions.
* Integrate Artem’s suggestions.
  * Correctly capitalize “AArch” in preparation of haskell#11047 backport
* Integrate Artem’s suggestions /II.
@ffaf1 ffaf1 force-pushed the 3.16-changelogs branch from 73f026f to ab9ee2c Compare July 8, 2025 15:08
@geekosaur
Copy link
Collaborator

Well, actually, I'm considering hijacking the significance field to generalize it. I don't think that'll be suitable for this kind of grouping, though; that would take more work.

Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, here's Copilot suggestions: https://gist.github.com/ulysses4ever/404e1a9e936f6101ea43fc4597339499 Nothing looks particularly great to me (they are mostly good in general but less so in our particular case, I feel). So, I'm ready to move on.

@ffaf1
Copy link
Collaborator Author

ffaf1 commented Jul 8, 2025

  1. Be Concise Where Possible

“Medice, cura te ipsum.” moment, dear Copilot.

I am putting the squash+merge me label!

@ffaf1 ffaf1 added the squash+merge me Tell Mergify Bot to squash-merge label Jul 8, 2025
@mergify mergify bot merged commit 8b69517 into haskell:3.16 Jul 8, 2025
57 checks passed
@ffaf1 ffaf1 deleted the 3.16-changelogs branch July 8, 2025 19:52
@ffaf1
Copy link
Collaborator Author

ffaf1 commented Jul 8, 2025

@mergify backport master

@mergify
Copy link
Contributor

mergify bot commented Jul 8, 2025

backport master

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 8, 2025
* Add changelog files for 3.16

* Integrate Brandon’s suggestions.
* Integrate Brandon’s suggestions /II.
* Integrate Bodigrim’s suggestions.
* Integrate Artem’s suggestions.
  * Correctly capitalize “AArch” in preparation of #11047 backport
* Integrate Artem’s suggestions /II.

* Remove changelog.d bits

(cherry picked from commit 8b69517)
ffaf1 added a commit to ffaf1/cabal that referenced this pull request Jul 10, 2025
* Add changelog files for 3.16

* Integrate Brandon’s suggestions.
* Integrate Brandon’s suggestions /II.
* Integrate Bodigrim’s suggestions.
* Integrate Artem’s suggestions.
  * Correctly capitalize “AArch” in preparation of haskell#11047 backport
* Integrate Artem’s suggestions /II.

* Remove changelog.d bits
@ffaf1 ffaf1 mentioned this pull request Jul 10, 2025
2 tasks
@mergify mergify bot added the merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days label Jul 10, 2025
zlonast pushed a commit to zlonast/cabal that referenced this pull request Aug 25, 2025
* Add changelog files for 3.16

* Integrate Brandon’s suggestions.
* Integrate Brandon’s suggestions /II.
* Integrate Bodigrim’s suggestions.
* Integrate Artem’s suggestions.
  * Correctly capitalize “AArch” in preparation of haskell#11047 backport
* Integrate Artem’s suggestions /II.

* Remove changelog.d bits
zlonast pushed a commit to zlonast/cabal that referenced this pull request Aug 26, 2025
* Add changelog files for 3.16

* Integrate Brandon’s suggestions.
* Integrate Brandon’s suggestions /II.
* Integrate Bodigrim’s suggestions.
* Integrate Artem’s suggestions.
  * Correctly capitalize “AArch” in preparation of haskell#11047 backport
* Integrate Artem’s suggestions /II.

* Remove changelog.d bits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

attention: needs-backport master merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days release squash+merge me Tell Mergify Bot to squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants