-
Notifications
You must be signed in to change notification settings - Fork 723
Add 3.16 changelogs #11033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 3.16 changelogs #11033
Conversation
f3ac4bc to
94018fa
Compare
I should go through again and catch typos and grammar issues
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't get to the meat yet
bc1e843 to
b37cd10
Compare
|
@ulysses4ever Once you are fine with these, I can put the |
|
@ffaf1 yeah, sorry, I'm swamped by the holidays in the US. I'll try to attend to it by Monday. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
baby steps...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's all I have for now. I want to do only one more thing: request copilot to review this PR (as an experiment), but that's after you look through my comments.
* Integrate Brandon’s suggestions. * Integrate Brandon’s suggestions /II. * Integrate Bodigrim’s suggestions. * Integrate Artem’s suggestions. * Correctly capitalize “AArch” in preparation of haskell#11047 backport * Integrate Artem’s suggestions /II.
|
Well, actually, I'm considering hijacking the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, here's Copilot suggestions: https://gist.github.com/ulysses4ever/404e1a9e936f6101ea43fc4597339499 Nothing looks particularly great to me (they are mostly good in general but less so in our particular case, I feel). So, I'm ready to move on.
“Medice, cura te ipsum.” moment, dear Copilot. I am putting the |
|
@mergify backport master |
✅ Backports have been created
|
* Add changelog files for 3.16 * Integrate Brandon’s suggestions. * Integrate Brandon’s suggestions /II. * Integrate Bodigrim’s suggestions. * Integrate Artem’s suggestions. * Correctly capitalize “AArch” in preparation of #11047 backport * Integrate Artem’s suggestions /II. * Remove changelog.d bits (cherry picked from commit 8b69517)
* Add changelog files for 3.16 * Integrate Brandon’s suggestions. * Integrate Brandon’s suggestions /II. * Integrate Bodigrim’s suggestions. * Integrate Artem’s suggestions. * Correctly capitalize “AArch” in preparation of haskell#11047 backport * Integrate Artem’s suggestions /II. * Remove changelog.d bits
* Add changelog files for 3.16 * Integrate Brandon’s suggestions. * Integrate Brandon’s suggestions /II. * Integrate Bodigrim’s suggestions. * Integrate Artem’s suggestions. * Correctly capitalize “AArch” in preparation of haskell#11047 backport * Integrate Artem’s suggestions /II. * Remove changelog.d bits
* Add changelog files for 3.16 * Integrate Brandon’s suggestions. * Integrate Brandon’s suggestions /II. * Integrate Bodigrim’s suggestions. * Integrate Artem’s suggestions. * Correctly capitalize “AArch” in preparation of haskell#11047 backport * Integrate Artem’s suggestions /II. * Remove changelog.d bits
Include the following checklist in your PR:
Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).Note: #10915 should be fixed by
--with-repl.