Skip to content

Add datadir env var before running the exe #4610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 20, 2017
Merged

Add datadir env var before running the exe #4610

merged 2 commits into from
Jul 20, 2017

Conversation

@fgaz
Copy link
Member

@fgaz fgaz commented Jul 19, 2017 •
edited
Loading

This enables the executale to find the datafiles in inplace builds.

Fixes #4120

  • Any changes that could be relevant to users have been recorded in the changelog. (this is part of new-run)
  • Added a test for this.

@mention-bot
Copy link

mention-bot commented Jul 19, 2017

@fgaz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dcoutts to be a potential reviewer.

@fgaz
Add datadir env var before running the exe
0c79706 
This enables the executale to find the datafiles in inplace builds.

Fixes haskell#4120
@fgaz fgaz added the cabal-install: v2-build system Affecting v2-build and related commands that use v2-architecture (aka "nix local builds"). label Jul 19, 2017
23Skidoo
23Skidoo approved these changes Jul 19, 2017
View reviewed changes
Copy link
Member

@23Skidoo 23Skidoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@fgaz
Add test for haskell#4120
de31b2a 
Datafiles should work when running an inplace exe
@ezyang ezyang merged commit c4e4edb into haskell:master Jul 20, 2017
@fgaz fgaz deleted the new-run/datafiles branch July 20, 2017 10:42
@Mikolaj
Copy link
Member

Mikolaj commented Jul 27, 2017

FYI: this doesn't work if you have cabal.project and different exes use data files listed in their respective .cabal files. :(

@fgaz
Copy link
Member Author

fgaz commented Jul 28, 2017 •
edited
Loading

@Mikolaj thanks for reporting the bug. looking into it.
edit: #4639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@23Skidoo 23Skidoo 23Skidoo approved these changes

Assignees

No one assigned

Labels

cabal-install: v2-build system Affecting v2-build and related commands that use v2-architecture (aka "nix local builds"). data-files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nix-style builds need to install data files for inplace builds

6 participants

@fgaz @mention-bot @Mikolaj @23Skidoo @ezyang @ulysses4ever