haskell-indent-align-def, via haskell-indent-start-of-def, causes type of definition to align with '='

[philipdexter]

Calling an align on

test :: Int -> Int -> Int
test x y = x
test x y     = y

gives

test     :: Int -> Int -> Int
test x y = x
test x y = y

I have looked briefly and I haven't found any Haskell code that uses this indentation style. I believe it should give

test :: Int -> Int -> Int
test x y = x
test x y = y

I have created a patch that changes

• haskell-indent-start-of-def to discard type lines (note: start-of-def is only called when P-ARG is nil)
• haskell-indent-align-guards-and-rhs to take a universal argument that switches on the P-ARG argument to haskell-indent-align-def

Result:

• to include type definitions in alignment prefix C-u

Thoughts?

There are other places in the alignment code that this could be changed. However I wanted to keep this fix simple and I didn't want to forbid aligning of code like

test :: Int
testSecond :: Int

to

test       :: Int
testSecond :: Int

[philipdexter]

Actually, for this to work properly, all of the insert methods will have to handle the C-u. Including insert-equal, insert-guard, and maybe more?

This might be too messy.

[philipdexter]

This seems to have been fixed in the case of haskell-indent-align-guards-and-rhs (sorry, hadn't fetched in a little while), but not in cases such as insert-equal and insert-guard

[ivan-m]

That style of alignment was rather popular at one stage I believe; I started using it early on when I started writing Haskell and only recently have stopped doing so.

[gracjan]

This issue has not seen activity for a very long time. Is this still something we should be concerned about?

[philipdexter]

It doesn't seem like it's a universal issue, closing