-
Notifications
You must be signed in to change notification settings - Fork 1
added flag for hemitrap #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
when testing private forks of heminetwork's production networks (i.e. testnet and mainnet), a few validations and features will need to be skipped (since the sequencer and other private keys/addresses change). this pr adds a flag to op-node: "--hemitrap.enabled", when this flag is TRUE disable certain validations, features, and data that would hinder the progression of a forked network. NOTE: this is NOT for production use
9466560 to
83aed2c
Compare
jcvernaleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor question but otherwise looks all good.
op-node/node/runtime_config.go
Outdated
| if err != nil { | ||
| return fmt.Errorf("failed to fetch unsafe block signing address from system config: %w", err) | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline added by mistake?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah yes, I can remove
jcvernaleo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
when testing private forks of heminetwork's production networks (i.e. testnet and mainnet), a few validations and features will need to be skipped (since the sequencer and other private keys/addresses change). this pr adds a flag to op-node: "--hemitrap.enabled", when this flag is TRUE disable certain validations, features, and data that would hinder the progression of a forked network.
NOTE: this is NOT for production use