Skip to content

Conversation

@ClaytonNorthey92
Copy link

@ClaytonNorthey92 ClaytonNorthey92 commented Oct 9, 2025

when testing private forks of heminetwork's production networks (i.e. testnet and mainnet), a few validations and features will need to be skipped (since the sequencer and other private keys/addresses change). this pr adds a flag to op-node: "--hemitrap.enabled", when this flag is TRUE disable certain validations, features, and data that would hinder the progression of a forked network.

NOTE: this is NOT for production use

@ClaytonNorthey92 ClaytonNorthey92 marked this pull request as draft October 9, 2025 20:20
when testing private forks of heminetwork's production networks (i.e. testnet and mainnet), a few validations and features will need to be skipped (since the sequencer and other private keys/addresses change).  this pr adds a flag to op-node: "--hemitrap.enabled", when this flag is TRUE disable certain validations, features, and data that would hinder the progression of a forked network.

NOTE: this is NOT for production use
@ClaytonNorthey92 ClaytonNorthey92 changed the title change needed for hemitrap added flag for hemitrap Oct 10, 2025
@ClaytonNorthey92 ClaytonNorthey92 marked this pull request as ready for review October 10, 2025 11:33
Copy link

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor question but otherwise looks all good.

if err != nil {
return fmt.Errorf("failed to fetch unsafe block signing address from system config: %w", err)
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline added by mistake?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, I can remove

Copy link

@jcvernaleo jcvernaleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

@ClaytonNorthey92 ClaytonNorthey92 merged commit 9cc3af2 into hemi Oct 10, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants