-
-
Notifications
You must be signed in to change notification settings - Fork 245
feat(client): added angular, axios, fetch, next & nuxt client type export for external typing purposes; #2535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🦋 Changeset detectedLatest commit: efdeedc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
@alexedme is attempting to deploy a commit to the Hey API Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2535 +/- ##
=======================================
Coverage 24.00% 24.00%
=======================================
Files 359 359
Lines 35540 35540
Branches 1540 1540
=======================================
Hits 8533 8533
Misses 26994 26994
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
@@ -1,5 +1,6 @@ | |||
import type { DefinePlugin, Plugin } from '../../types'; | |||
import type { Client } from '../client-core/types'; | |||
export type { Client as AngularClient } from './bundle/types'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to re-export from both types and index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fault.
The change in the types file is redundant and not necessary. At first, I thought of creating a new type in the following way:
import type { Client } from './bundle/types';
export AxiosClient = Client
But opted afterwards to simply re-export the type with an alias to avoid conflict with Client namespace (packages/openapi-ts/src/plugins/@hey-api/client-core/types.d.ts line 17).
I will revert the changes in the types file.
Thank you for letting me know.
@alexedme you can use the previews to verify it works as expected on your end once actually released |
…port for external typing purposes;
6757b16
to
efdeedc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good – thank you!
I should to be the one thanking you for allowing me to contribute to this great lib. It was a nice experience. |
feat(client): added angular, axios, fetch, next & nuxt client type export for external typing purposes;
Closes #2533