Skip to content

Conversation

@mrlubos
Copy link
Member

@mrlubos mrlubos commented Oct 21, 2025

Related #1473
Closes #2672

TODO

  • fix Valibot tests

@bolt-new-by-stackblitz
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot
Copy link

changeset-bot bot commented Oct 21, 2025

🦋 Changeset detected

Latest commit: 022f7dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@hey-api/openapi-ts Patch
@hey-api/codegen-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hey-api-docs Ready Ready Preview Comment Oct 23, 2025 1:41am

@mrlubos mrlubos marked this pull request as ready for review October 21, 2025 10:46
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Oct 21, 2025
@dosubot dosubot bot added internal ⚙️ Internal development related javascript Pull requests that update Javascript code labels Oct 21, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 22, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 18.98216% with 2770 lines in your changes missing coverage. Please review.
✅ Project coverage is 30.26%. Comparing base (fb9460b) to head (022f7dd).
⚠️ Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/openapi-ts/src/plugins/valibot/v1/plugin.ts 5.43% 261 Missing ⚠️
...ages/openapi-ts/src/plugins/@hey-api/sdk/plugin.ts 0.00% 215 Missing ⚠️
.../openapi-ts/src/plugins/valibot/v1/toAst/number.ts 2.35% 207 Missing ⚠️
packages/openapi-ts/src/plugins/arktype/config.ts 8.87% 195 Missing ⚠️
...ckages/openapi-ts/src/plugins/arktype/v2/plugin.ts 6.25% 165 Missing ⚠️
...es/openapi-ts/src/plugins/shared/utils/instance.ts 22.03% 138 Missing ⚠️
.../openapi-ts/src/plugins/valibot/v1/toAst/string.ts 3.10% 125 Missing ⚠️
.../openapi-ts/src/plugins/arktype/v2/toAst/object.ts 5.35% 106 Missing ⚠️
...s/openapi-ts/src/plugins/valibot/v1/toAst/index.ts 11.71% 98 Missing ⚠️
...s/openapi-ts/src/plugins/valibot/v1/toAst/array.ts 7.61% 97 Missing ⚠️
... and 51 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2812      +/-   ##
==========================================
+ Coverage   29.15%   30.26%   +1.10%     
==========================================
  Files         391      465      +74     
  Lines       38104    39585    +1481     
  Branches     2272     2406     +134     
==========================================
+ Hits        11109    11980     +871     
- Misses      26965    27574     +609     
- Partials       30       31       +1     
Flag Coverage Δ
unittests 30.26% <18.98%> (+1.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 23, 2025

Open in StackBlitz

npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/codegen-core@2812
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/nuxt@2812
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/openapi-ts@2812
npm i https://pkg.pr.new/hey-api/openapi-ts/@hey-api/vite-plugin@2812

commit: 022f7dd

@mrlubos mrlubos force-pushed the feat/arktype-plugin branch from 0f46a9c to 7682129 Compare October 23, 2025 00:50
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Oct 23, 2025
@mrlubos mrlubos force-pushed the feat/arktype-plugin branch from 7682129 to 022f7dd Compare October 23, 2025 01:41
@mrlubos mrlubos merged commit 72a79cc into main Oct 23, 2025
16 of 17 checks passed
@mrlubos mrlubos deleted the feat/arktype-plugin branch October 23, 2025 01:50
@hey-api hey-api bot mentioned this pull request Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal ⚙️ Internal development related javascript Pull requests that update Javascript code size:XL This PR changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Zod Plugin] Variable used before declaration in OpenAPI schema with circular references

1 participant