HH-125740 added dc, recurse and cold-start health cache #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzharikhin
reviewed
Apr 9, 2021
consul/base.py
Outdated
| service=service, | ||
| passing=passing, | ||
| dc=dc, | ||
| )[1]} |
There was a problem hiding this comment.
сделай через матчинг
_, service_health = health_client.service(...
self.cache = {self.service: service_health}
понять, что там за [1] куда сложнее будет
dzharikhin
approved these changes
Apr 12, 2021
dzharikhin
reviewed
Apr 12, 2021
| passing=passing, | ||
| dc=dc, | ||
| ) | ||
| self.cache = {self.service: service_health} |
There was a problem hiding this comment.
кстати, мб индекс можно и использовать вполне, чтобы запрос из кеша сразу с индексом отправлять
There was a problem hiding this comment.
Кстати да) это прям очень хорошо будет. Сейчас вставлю
There was a problem hiding this comment.
Готово! Проверил, все как надо идёт)
nicholasgribanov
force-pushed
the
HH-125740
branch
from
24925a5 to
3dbb43c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.