Skip to content

Conversation

@yrodiere
Copy link
Member

@yrodiere yrodiere commented Jun 16, 2025

https://hibernate.atlassian.net/browse/HHH-19548


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Jun 16, 2025

Thanks for your pull request!

This pull request appears to follow the contribution rules.

› This message was automatically generated.

@yrodiere
Copy link
Member Author

We have a test failure on JDK 26 specifically: https://develocity.commonhaus.dev/s/7e6ebrxmwnowq/tests/task/:hibernate-envers:test/details/org.hibernate.orm.test.envers.integration.lazy.LazyFieldsTest/testUpdate(SessionFactoryScope)?expanded-stacktrace=WyIwLTEtMiJd&top-execution=1

However, since the purpose of this PR is JDK 25 support, and I just added JDK 26 as a matter of course, I'd be inclined to merge, and investigate later.

@beikov do you concur?

@beikov
Copy link
Member

beikov commented Jun 18, 2025

Merging this is fine IMO, but AFAICT, JDK 26 simply has a bug in the ClassFile API, so it might be worth reporting this.

@yrodiere yrodiere merged commit 106200b into hibernate:main Jun 19, 2025
27 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants