sync some code in ReactiveSessionImpl with core SessionImpl #1585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| CompletionStage<Object> reactiveImmediateLoad(String entityName, Object id); | ||
|
|
||
| CompletionStage<Void> reactiveInitializeCollection(PersistentCollection collection, boolean writing); | ||
| CompletionStage<Void> reactiveInitializeCollection(PersistentCollection<?> collection, boolean writing); |
Check notice
Code scanning / CodeQL
Useless parameter
also remove some unnecessary operations of ReactiveQueryProducer also fill in some missing method implementations
| } | ||
|
|
||
| String previousFetchProfile = getLoadQueryInfluencers().getInternalFetchProfile(); | ||
| final String previousFetchProfile = getLoadQueryInfluencers().getInternalFetchProfile(); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| @Override | ||
| public <T> CompletionStage<T> reactiveFind(Class<T> entityClass, Map<String, Object> ids) { | ||
| EntityPersister persister = getFactory().getMetamodel().locateEntityPersister( entityClass ); | ||
| final EntityPersister persister = getFactory().getMetamodel().locateEntityPersister( entityClass ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
| @Override | ||
| public <T> CompletionStage<T> reactiveFind(Class<T> entityClass, Map<String, Object> ids) { | ||
| EntityPersister persister = getFactory().getMetamodel().locateEntityPersister( entityClass ); | ||
| final EntityPersister persister = getFactory().getMetamodel().locateEntityPersister( entityClass ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.