Skip to content

fix(modal): close method not being invoked #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(modal): close method not being invoked #108

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/ui/src/controlled-modal/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ export const ControlledModal: MemoExoticComponentWithAs<ModalProps, 'dialog'> =
const { children, isOpen = false, handleClose, noAnimation = false, ...rest } = props;
const onCloseHandler = isOpen ? handleClose : () => null;

useOnClickOutside(_ref, isOpen ? onCloseHandler : null);
useOnClickOutside(_ref, onCloseHandler);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you go into more detail about why this needs to be the case? I made this change originally because having the handler always on is a significant performance drain.

useHotkeys('esc', onCloseHandler, [onCloseHandler]);

return (
Expand Down