Skip to content

Pyclef pythonsigner.py upgrades #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 2, 2022
Merged

Pyclef pythonsigner.py upgrades #29

merged 6 commits into from
May 2, 2022

Conversation

kvbik
Copy link

@kvbik kvbik commented Mar 15, 2022 •
edited
Loading

  • black autoformatting
  • linter
  • define requirements
  • additional fixes
  • try to run it!!!

@kvbik kvbik requested a review from holiman as a code owner March 15, 2022 14:45
@kvbik kvbik mentioned this pull request Mar 15, 2022
Merged
@holiman
Copy link
Owner

holiman commented Mar 15, 2022

LGTM, should I hold with merging this until you've ticked all boxes?

@holiman
Copy link
Owner

holiman commented Mar 30, 2022

Looking good. Should I merge?

@holiman holiman merged commit dc6fd48 into holiman:pyclef May 2, 2022
@holiman
Copy link
Owner

holiman commented May 2, 2022

Thanks @kvbik !

holiman pushed a commit that referenced this pull request Jul 7, 2023
@corwintines
fix footer regression (#29)
86ada0d 
* fix footer regression

* fix social icon and copyright date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@holiman holiman Awaiting requested review from holiman holiman is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kvbik @holiman