Split features and move battery and tx_busy values to base entity #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mib1185
force-pushed
the
split-devices-by-features
branch
from
90eb28a to
c7e722f
Compare
|
since #95 is merged please rebase |
mib1185
force-pushed
the
split-devices-by-features
branch
from
ee65fb6 to
a373d8f
Compare
|
I agree with codeclimate result, but it complains already existing code, so i'm not sure if we should refactor this within that PR? |
I'm fine with that. |
|
Hi @hthiery |
|
I just sent you a request on discord. Maybe we can discuss that there.
Am Mo., 15. Jan. 2024 um 10:40 Uhr schrieb Michael ***@***.***
…:
Hi @hthiery <https://github.com/hthiery>
thanks for merging all these PRs 👍 do you mind or has already planned to
release a new version?
—
Reply to this email directly, view it on GitHub
<#96 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABSFGUTROQOJ4DJNB24QFALYOT2RZAVCNFSM6AAAAABB2GUA4OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOJRG4YDQMBWGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will split the humidity and level related features into own classes, so they can be used by any sub device unit (eq. separate sensor units on devices).
To further follow this concept, the battery related and tx_busy values are moved to the base entity. Nevertheless, the battery values from
hkrnode (thermostat) are kept for backwards compatibility with Fritz!OS < 7.08.Last but not least, there are also some debug logging added.