Skip to content

Conversation

willtsai
Copy link
Contributor

@willtsai willtsai commented Nov 24, 2021

Description

Before submitting a PR:

We love getting PRs, but we hate asking people for the same basic changes every time.

  • Push your changes to a branch other than main. Create your PR from that branch.
  • Add JavaDocs and other comments
  • Write tests that run and pass in CI. See CONTRIBUTING.md for details on how to capture snapshot data.
  • Run mvn -D enable-ci clean install site locally. If this command doesn't succeed, your change will not pass CI.

When creating a PR:

  • Fill in the "Description" above.
  • Enable "Allow edits from maintainers".

Fixes #1243

@willtsai
Copy link
Contributor Author

willtsai commented Nov 24, 2021

Note: I chose to implement with a single GHCommentChanges.java wrapper class since the Webhook payload for both issue comments change and pull request review comment changes are identical, e.g.

  "changes": {
    "body": {
      "from": "pull request comment BEFORE edit"
    }
  },

@codecov
Copy link

codecov bot commented Nov 24, 2021

Codecov Report

Merging #1322 (cf6ded0) into main (d576643) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1322      +/-   ##
============================================
+ Coverage     78.15%   78.17%   +0.02%     
  Complexity     2045     2045              
============================================
  Files           200      200              
  Lines          6277     6283       +6     
  Branches        356      356              
============================================
+ Hits           4906     4912       +6     
  Misses         1162     1162              
  Partials        209      209              
Impacted Files Coverage Δ
...c/main/java/org/kohsuke/github/GHEventPayload.java 80.41% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d576643...cf6ded0. Read the comment docs.

@willtsai
Copy link
Contributor Author

Committed changes to move CommentChanges into static class within GHEventPayload. Please review again, thanks!

@bitwiseman bitwiseman merged commit cbe8548 into hub4j:main Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing GHIssueCommentChanges
3 participants