Skip to content

Conversation

@kalixlouiis
Copy link
Contributor

This PR provides refinements to the Myanmar translation for Chapter 0, Section 1 (1.mdx).

  • Updated Terminology: Key terms and phrases have been re-evaluated and adjusted for improved clarity and consistency, making the content more accessible.
  • Expanded Glossary: The per-chapter glossary has been updated with additional technical terms to further aid reader comprehension.

@lewtun, @stevhliu, and @sittyatenyo - please review these updates.

Closes #1042

Copy link
Contributor

@sittyatenyo sittyatenyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have thoroughly reviewed the updated Myanmar translation for Chapter 0, Section 1.
The refinements made have significantly improved clarity and accuracy. The terminology usage and glossary updates are also well-implemented. This version is accurate and ready for merge.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The doc-builder is failing on chapter1/7 on question 2. I think it may be related to a parsing issue. Can you try changing to:

choices={[
  {
    text: `၎င်းသည် ဤစာကြောင်းအတွက် ခွဲခြားသတ်မှတ်ခြင်း အမှတ်များ ("positive" သို့မဟုတ် "negative" အညွှန်းများဖြင့်) ကို ပြန်ပေးပါလိမ့်မည်။`,
    explain: `ဒါက မမှန်ကန်ပါဘူး — ဒါက \`sentiment-analysis\` pipeline ဖြစ်ပါလိမ့်မယ်။`
  },

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@kalixlouiis
Copy link
Contributor Author

Thanks!

The doc-builder is failing on chapter1/7 on question 2. I think it may be related to a parsing issue. Can you try changing to:

choices={[
  {
    text: `၎င်းသည် ဤစာကြောင်းအတွက် ခွဲခြားသတ်မှတ်ခြင်း အမှတ်များ ("positive" သို့မဟုတ် "negative" အညွှန်းများဖြင့်) ကို ပြန်ပေးပါလိမ့်မည်။`,
    explain: `ဒါက မမှန်ကန်ပါဘူး — ဒါက \`sentiment-analysis\` pipeline ဖြစ်ပါလိမ့်မယ်။`
  },

Thank you for pinpointing the exact issue!

I have applied the suggested fix for the parsing issue in chapter1/7.mdx. The PR has been updated with this fix and is now ready for re-review.

@stevhliu stevhliu merged commit 8c0e498 into huggingface:main Sep 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Translation to Myanmar (my)

4 participants