Skip to content

Conversation

blackdoor571
Copy link
Contributor

No description provided.

@ArthurZucker
Copy link

Awesome work! 🤗
In order to have a preview, you need to add the chapters to the chapters/ja/_toctree.yml as in #363 👍🏻
Then we'll be able to make sure it renders well

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@fxmarty
Copy link
Contributor

fxmarty commented Nov 4, 2022

This is super cool ️‍🔥 I was thinking it could be nice to have examples in Japanese throughout the course, what do you think? Just a suggestion!

Copy link
Member

@lewtun lewtun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this great translation @blackdoor571 and welcome to the 🤗 community!

I think @fxmarty's idea to use Japanese models is nice, but probably best done directly in the notebooks to ensure the course content is 1-1 across languages. No need to do that yourself, but just making a note here for other translators :)

There's a small code styling issue with the PR - could you please install the requirements and run make style?

@fxmarty
Copy link
Contributor

fxmarty commented Nov 4, 2022

@lewtun Makes sense. Here's an example of how it was done in the French translation, with comments: https://huggingface.co/course/fr/chapter1/3?fw=pt . Honestly I'm not fan of putting comments everywhere (everything feels like less readable), but I see the point where there may be readers not able to grasp examples in English. I agree we could keep everything in English and leave translated example in future notebooks though.

@lewtun
Copy link
Member

lewtun commented Nov 10, 2022

Hey @blackdoor571 thanks for this great translation! We just merged #359 which created some merge conflicts on the _toctree.yml file. Would you mind rebasing / merging with main and pushing again? Thanks!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@younesbelkada
Copy link
Contributor

Thank you very much @blackdoor571 for your great contribution!! Merging

@younesbelkada younesbelkada merged commit 7081ab6 into huggingface:main Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants