Skip to content

Conversation

@hlky
Copy link
Contributor

@hlky hlky commented Mar 7, 2025

What does this PR do?

Wan VAE move scaling to pipeline

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@yiyixuxu yiyixuxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!
looks good! feel free to merge once make sure outputs are same :)

@hlky hlky merged commit 363d1ab into huggingface:main Mar 7, 2025
11 of 12 checks passed
@wangqixun
Copy link
Contributor

These two ways are not equivalent.
Consider the following details
image

@hlky
Copy link
Contributor Author

hlky commented Mar 19, 2025

@wangqixun We confirmed the outputs from this PR are the same as the original PR. Later, an issue was discovered that existed in the original PR, see #11087 for details. If you believe otherwise contributions are welcome :)

@DN6 DN6 moved this from In Progress to Done in Diffusers Roadmap 0.36 Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants