Add UV script comment block #12036
Draft
Add UV script comment block #12036
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR makes our advanced diffusion training compatible with uv, which therefore also makes them compatible with Hugging Face jobs: https://huggingface.co/docs/huggingface_hub/en/guides/jobs The idea is to test it out with this PR, working well we could expand the uv comment for all diffusers scripts to add both uv and hf jobs compatibility
|
@apolinario @sayakpaul since sayak's open PR covers this script as well, lets maybe just add the additional dependencies in this PR to the advanced block in #12000 ? |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Thanks, sorry for missing it. Yeah, I think we need a few more deps for the advanced scripts. Let's chat on @sayakpaul's PR then! |
|
I used |
|
Gotcha. I'll keep this PR then and merge yours to it and add the deps for the advanced script on top of it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes our advanced diffusion training compatible with uv, which therefore also makes them compatible with Hugging Face jobs: https://huggingface.co/docs/huggingface_hub/en/guides/jobs
The idea is to test it out with this PR, working well we could expand the uv comment for all diffusers scripts to add both uv and hf jobs compatibility
cc @sayakpaul @linoytsaban