Skip to content

Conversation

@Patil-Ojas
Copy link
Contributor

List of changes made to chat_templates_example:

  1. added install libraries cell
  2. removed .mps from AutoModelForCausalLM function
  3. typo in Conversation
  4. Attempted to address error TypeError: argument 'ids': Can't extract str to Vec by adding -
    added tokenized_text = tokenizer(input_text, return_tensors="pt")["input_ids"].squeeze().tolist(), please check once

List of changes made to sft_finetuning_example:

  1. added install libraries cell
  2. removed .mps from AutoModelForCausalLM function
  3. removed .mps from SFTConfig function

@burtenshaw
Copy link
Collaborator

Hey, if you push your notebooks to your fork branch, we will be able to see you work and review. 😄 https://colab.research.google.com/github/googlecolab/colabtools/blob/master/notebooks/colab-github-demo.ipynb

@burtenshaw burtenshaw changed the title Changes to Colab Notebook Links in 1_instruction_tuning/README.md [SUBMISSION] Changes to Colab Notebook Links in 1_instruction_tuning/README.md Dec 3, 2024
@Patil-Ojas
Copy link
Contributor Author

Apologies & thank you for the resource.

I've added the Google Colab versions of the notebooks to https://github.com/huggingface/smol-course/tree/main/1_instruction_tuning/notebooks and then changed their links in the respective ReadMe accordingly.

If this isn't the correct way or this is not the how you intended it to be, please let me know.

@burtenshaw
Copy link
Collaborator

This looks great. Could you move your notebook to a location other than the original notebook. For example, like this:

{module}/notebooks/students/{student_name}/{notebook}

Copy link
Collaborator

@burtenshaw burtenshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'll merge because I haven't heard back from you. Join the discord to Discuss:

https://discord.com/channels/879548962464493619/1313889336907010110

@burtenshaw burtenshaw changed the base branch from main to december-2024 December 11, 2024 12:38
@burtenshaw burtenshaw merged commit 7c5bb78 into huggingface:december-2024 Dec 11, 2024
@Patil-Ojas
Copy link
Contributor Author

Apologies for the inactivity- I was tied up with end-semester exams. I'll join the Discord server to discuss the structure and continue with the work.

zcasanova pushed a commit to zcasanova/smol-course that referenced this pull request Dec 27, 2024
[SUBMISSION] Changes to Colab Notebook Links in 1_instruction_tuning/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants