Skip to content

Conversation

@smdesai
Copy link
Contributor

@smdesai smdesai commented May 12, 2025

This change provides support for IBM's Granite model. The tags defined in the template are of the form:
{%- if available_tools and documents %}
{%- elif thinking %}

which fail right whilst the following work.
{%- if available_tools is defined and available_tools and documents is defined and documents %}
{%- elif thinking is defined and thinking %}

If the variables are defined and they evaluate to true, the condition holds otherwise they are treated as false.

Also added support for the function strftime_now

@johnmai-dev johnmai-dev self-requested a review May 13, 2025 04:41
Copy link
Collaborator

@johnmai-dev johnmai-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!
Refine the test cases, and we can merge this PR.

@johnmai-dev johnmai-dev self-requested a review May 14, 2025 04:48
Copy link
Collaborator

@johnmai-dev johnmai-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@johnmai-dev johnmai-dev merged commit 8879db4 into huggingface:main May 14, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants