-
Notifications
You must be signed in to change notification settings - Fork 31.1k
Mention no images added to repository #14738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| example. | ||
| 7. Due to the rapidly growing repository, it is important to make sure that no file that would significantly weigh down | ||
| the repository are added. This includes images, videos and other non-text files. We prefer to leverage a hf.co hosted `dataset` like | ||
| the ones hosted on [`hf-internal-testing`](https://huggingface.co/hf-internal-testing) in which to place these files and reference |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI the repo I use for documentation images is called "documentation-images": https://huggingface.co/datasets/huggingface/documentation-images
sgugger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this note. As said on another PR, I think it would be more efficient to couple this with a migration of existing images to the same dataset and completely remove the imgs folder, this way no one will be tempted to add an image.
Co-authored-by: NielsRogge <[email protected]>
|
WIll merge this as a first step! |
|
Merged too soon? We need a concrete destination for images that we all share. |
|
but it's not part of this PR that was merged. i.e. @NielsRogge's suggestion wasn't integrated into the doc. additionally please please keep these instructions in |
Mention that images shouldn't be added to the repository as it will otherwise significantly weigh down the repository.