Skip to content

Conversation

@mathieujouffroy
Copy link
Contributor

What does this PR do?

This PR aims to rectify the difference in parameter initialization between the HF implementation and the original implementation (microsoft).

  • Initializes torch dense layer weights with trunc_normal instead of normal.
  • Initializes cls_token with trunc_normal

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • [] Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

As discussed @amyeroberts here's the PR regarding the changes for the CvT pytorch model 😊

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 11, 2022

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks for the fix! Sorry, I was going through my github notifications and didn't see it was merged. Still thank you for the fix though :)

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the records, this is the same thing as in #19341

@sgugger sgugger merged commit f4ef78a into huggingface:main Oct 12, 2022
@mathieujouffroy mathieujouffroy deleted the cvt-param-init branch October 13, 2022 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants