Skip to content

🌐[i18n-KO] Translate autoclass_tutorial to Korean and Fix the typo of quicktour #22533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2023
Merged

🌐[i18n-KO] Translate autoclass_tutorial to Korean and Fix the typo of quicktour #22533

merged 1 commit into from
Apr 7, 2023

Conversation

@gabrielwithappy
Copy link
Contributor

@gabrielwithappy gabrielwithappy commented Apr 3, 2023 •
edited
Loading

What does this PR do?

Translated the autoclass_tutorial.mdx file of the documentation to Korean and fix the typo of quicktour
Thank you in advance for your review.

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

Review result

  • fix a wrong source code link of functions in the document

Links for API documents are not activated. I checked other language documents have same problem. I think it will be fixed when API documents are translated.

@gabrielwithappy gabrielwithappy mentioned this pull request Apr 3, 2023
Open
84 tasks
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 3, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

sgugger
sgugger approved these changes Apr 3, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation! Let us know when it's good to merge.

@gabrielwithappy
Copy link
Contributor Author

gabrielwithappy commented Apr 3, 2023 •
edited
Loading

  • need to add the english link of Load pretrained instances with an AutoClass
  • keep the AutoClass as a english

gabrielwithappy
gabrielwithappy commented Apr 3, 2023
View reviewed changes
Copy link
Contributor Author

@gabrielwithappy gabrielwithappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked

wonhyeongseo
wonhyeongseo reviewed Apr 4, 2023
View reviewed changes
docs/source/ko/quicktour.mdx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this sir!

@gabrielwithappy
Copy link
Contributor Author

squashed commit messages and check a final document result.

@gabrielwithappy
Copy link
Contributor Author

@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd
Please review thie PR.
Thank you in advance.

HanNayeoniee
HanNayeoniee reviewed Apr 5, 2023
View reviewed changes
HanNayeoniee
HanNayeoniee reviewed Apr 5, 2023
View reviewed changes
docs/source/ko/autoclass_tutorial.mdx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막으로 AutoModelFor클래스를 사용하면 주어진 작업에 대해 미리 학습된 모델을 로드할 수 있습니다 (사용 가능한 작업의 전체 목록은 여기를 참조하세요). 예를 들어, AutoModelForSequenceClassification.from_pretrained를 사용하여 시퀀스 분류용 모델을 로드할 수 있습니다:

docs/source/ko/autoclass_tutorial.mdx Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막으로 TFAutoModelFor 클래스를 사용하면 주어진 작업에 대해 사전 훈련된 모델을 로드할 수 있습니다. (사용 가능한 작업의 전체 목록은 여기를 참조하세요. 예를 들어, TFAutoModelForSequenceClassification.from_pretrained로 시퀀스 분류를 위한 모델을 로드합니다:

@gabrielwithappy
Copy link
Contributor Author

gabrielwithappy commented Apr 5, 2023 •
edited
Loading

[Korean]
음.. 좀 헷갈리네요. 링크가 안되는 이유가 뭔지 좀 알아봐야 될 것 같습니다.
소스코드에 링크가 안걸리는게 문제 같습니다. 좀 더 찾아볼께요
[English]
I will check why the hyperlink does not work.
I think I missed somthing on link code of source codes in the document

@gabrielwithappy
Copy link
Contributor Author

gabrielwithappy commented Apr 6, 2023 •
edited
Loading

Thank you.
I found my source code links are wrong.
I updated review action items and fix it @HanNayeoniee

@gabrielwithappy gabrielwithappy changed the title [WIP]🌐[i18n-KO] Translate autoclass_tutorial to Korean and Fix the typo of quicktour 🌐[i18n-KO] Translate autoclass_tutorial to Korean and Fix the typo of quicktour Apr 6, 2023
@gabrielwithappy
Copy link
Contributor Author

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

@sgugger sgugger merged commit d59034f into huggingface:main Apr 7, 2023
@sgugger
Copy link
Collaborator

sgugger commented Apr 7, 2023

Thanks for your contribution!

wonhyeongseo
wonhyeongseo reviewed Apr 7, 2023
View reviewed changes
Copy link
Contributor

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on your first PR merge for HuggingFace, @gabrielwithappy ! 🎉 🎉 🎉
I'm really excited to continue learning/working with you, and hope we can create something fun as well.

P.S. I forgot to post my reviews 😅 May I leave them in a sub-issue as we did with @jungnerd and #22549 ? Most issues are minor, but there is an outstanding issue on L13 we need to resolve.

docs/source/ko/autoclass_tutorial.mdx Outdated
Copy link
Contributor

@wonhyeongseo wonhyeongseo Apr 4, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

마지막 문장이 잘 읽히지 않아요. ~는 것의 표현을 쓰시기 보다 어절 간의 배열을 바꿔보시면 어떨까요?

HanNayeoniee
HanNayeoniee reviewed Apr 9, 2023
View reviewed changes
@gabrielwithappy gabrielwithappy mentioned this pull request Apr 12, 2023
Merged
5 tasks
@gabrielwithappy gabrielwithappy deleted the ko_translation branch April 14, 2023 01:15
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@gabrielwithappy @novice03
🌐[i18n-KO] Translate autoclass_tutorial to Korean and Fix the typo …
23b4c2c 
…of `quicktour` (huggingface#22533)

translate the autoclass_tutorial and fix the typo of the quicktour
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@wonhyeongseo wonhyeongseo wonhyeongseo left review comments

@HanNayeoniee HanNayeoniee HanNayeoniee left review comments

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gabrielwithappy @HuggingFaceDocBuilderDev @sgugger @wonhyeongseo @HanNayeoniee