Skip to content

Conversation

@0525hhgus
Copy link
Contributor

@0525hhgus 0525hhgus commented Apr 7, 2023

What does this PR do?

Translated the tasks/sequence_classification.mdx file of the documentation to Korean.

  • The file name is sequence_classification.mdx, but the document name is text classification.
  • Currently, it is being revised to consistent vocabulary.

Thank you in advance for your review:)

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Team PseudoLab, may you please review this PR?

@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 7, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@gabrielwithappy gabrielwithappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my review

@0525hhgus 0525hhgus force-pushed the ko-text_classification branch from 9dee25b to f3c32ab Compare April 8, 2023 03:27
Copy link
Contributor

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check my review? 🌟

wonhyeongseo

This comment was marked as duplicate.

wonhyeongseo

This comment was marked as duplicate.

Copy link
Contributor

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, splendid work @0525hhgus ! Please take these comments as talking points rather than direct fixes. Thank you for your hard work, have a great Sunday evening! 😸

@0525hhgus 0525hhgus force-pushed the ko-text_classification branch from ac22ec0 to 4018ffb Compare April 11, 2023 14:06
@0525hhgus 0525hhgus marked this pull request as ready for review April 11, 2023 14:10
Copy link
Contributor

@sim-so sim-so left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저는 모두 좋습니다 👍
고생 많으셨습니다!

@0525hhgus 0525hhgus force-pushed the ko-text_classification branch from 4018ffb to 3b104ac Compare April 13, 2023 14:03
@0525hhgus 0525hhgus changed the title [WIP] 🌐 [i18n-KO] Translated sequence_classification.mdx to Korean 🌐 [i18n-KO] Translated sequence_classification.mdx to Korean Apr 13, 2023
@0525hhgus
Copy link
Contributor Author

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thnaks for your contribution!

@sgugger sgugger merged commit bfb3925 into huggingface:main Apr 14, 2023
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…ngface#22655)

* docs: ko: init: tasks/sequence_classification.mdx

* docs: ko: revised: change voca in tasks/sequence_classification.mdx

* docs: ko: revised: [RE] change voca in tasks/sequence_classification.mdx

* docs: ko: revised: spell check and sentence naturally in tasks/sequence_classification.mdx

* docs: ko: revised: spell check and consistent vocabulary in tasks/sequence_classification.mdx

* docs: ko: revised: Add full stop and change voca in tasks/sequence_classification.mdx

* docs: ko: revised: sync first section templates in tasks/sequence_classification.mdx

Co-authored-by: Wonhyeong Seo <[email protected]>

* fix: revert use of full-stops to colons

* colons are used to emphasize the code block that follows

* @0525hhgus @wonhyeongseo docs: ko: revised: sync second section templates in tasks/sequence_classification.mdx

Co-Authored-By: Wonhyeong Seo <[email protected]>

* docs: ko: revised: change 'train', 'finetuning' in tasks/sequence_classification.mdx

---------

Co-authored-by: Wonhyeong Seo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants