Skip to content

🌐 [i18n-KO] Translated tasks/summarization.mdx to Korean #22783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2023
Merged

🌐 [i18n-KO] Translated tasks/summarization.mdx to Korean #22783

merged 1 commit into from
Apr 24, 2023

Conversation

@sim-so
Copy link
Contributor

@sim-so sim-so commented Apr 15, 2023 •
edited
Loading

What does this PR do?

Translated the tasks/summarization.mdx file of the documentation to Korean.
Thank you in advance for your review!

Part of #20179

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

This is a work on progress.
Could you review this PR when I finish this work?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

@wonhyeongseo wonhyeongseo mentioned this pull request Apr 17, 2023
Open
84 tasks
@sim-so
Copy link
Contributor Author

sim-so commented Apr 17, 2023

Team Pseudo Lab,
I'm happy to inform you I finished the translation!
Could you review this PR?

@sim-so sim-so changed the title [i18n-KO] Translated tasks/summarization.mdx to Korean 🌐 [i18n-KO] Translated tasks/summarization.mdx to Korean Apr 17, 2023
@sim-so sim-so changed the title 🌐 [i18n-KO] Translated tasks/summarization.mdx to Korean 🌐 [i18n-KO] Translated tasks/summarization.mdx to Korean Apr 17, 2023
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Apr 17, 2023 •
edited
Loading

The documentation is not available anymore as the PR was closed or merged.

wonhyeongseo
wonhyeongseo suggested changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@wonhyeongseo wonhyeongseo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your writing ✍️ is on-par with the best 👌
I can read through your work with a cadence that resembles birds🕊 flying through the sky. Keep up the good work, @sim-so !

docs/source/ko/tasks/summarization.mdx Outdated
Copy link
Contributor

@wonhyeongseo wonhyeongseo Apr 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

학습률 스케줄 부분이 조금 어색하군요. 대안이 당장 안 떠올라요.

Copy link
Contributor Author

@sim-so sim-so Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 고민하다가 시간이 좀 걸릴 것 같아서 이대로 진행했습니다.
용어사전에 추가해두고, 생각나면 바꾸는 걸로 하겠습니다!

sim-so
sim-so commented Apr 18, 2023
View reviewed changes
Copy link
Contributor Author

@sim-so sim-so left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always learn from your review! Thank you!
I changed the lines as you suggested. 😄 @wonhyeongseo

docs/source/ko/tasks/summarization.mdx Outdated
Copy link
Contributor Author

@sim-so sim-so Apr 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

저도 고민하다가 시간이 좀 걸릴 것 같아서 이대로 진행했습니다.
용어사전에 추가해두고, 생각나면 바꾸는 걸로 하겠습니다!

gabrielwithappy
gabrielwithappy reviewed Apr 18, 2023
View reviewed changes
0525hhgus
0525hhgus reviewed Apr 18, 2023
View reviewed changes
Copy link
Contributor

@0525hhgus 0525hhgus left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the good translation!
Your translation is easy to understand 😀
I leave a short review below.

@sim-so sim-so marked this pull request as ready for review April 22, 2023 08:41
@sim-so
Copy link
Contributor Author

sim-so commented Apr 22, 2023

Could you review this PR? 😄
@sgugger, @ArthurZucker, @eunseojo

@sim-so sim-so force-pushed the summarization branch 5 times, most recently from 56a03c4 to d726870 Compare April 23, 2023 13:30
@sim-so @0525hhgus
@jungnerd @wonhyeongseo @HanNayeoniee @gabrielwithappy @kihoon71
docs: ko: tasks/summarization.mdx
729be64 
Co-Authored-By: Hyeonseo Yun <[email protected]>
Co-Authored-By: Jungnerd <[email protected]>
Co-Authored-By: Wonhyeong Seo <[email protected]>
Co-Authored-By: Nayeon Han <[email protected]>
Co-Authored-By: Gabriel Yang <[email protected]>
Co-Authored-By: Kihoon Son <[email protected]>
sgugger
sgugger approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@sgugger sgugger merged commit 84097f6 into huggingface:main Apr 24, 2023
@sim-so sim-so deleted the summarization branch April 24, 2023 13:11
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
@sim-so @0525hhgus
@jungnerd @wonhyeongseo @HanNayeoniee @gabrielwithappy @kihoon71 @gojiteji
🌐 [i18n-KO] Translated tasks/summarization.mdx to Korean (huggingfa…
0bdba17 
…ce#22783)

docs: ko: tasks/summarization.mdx

Co-authored-by: Hyeonseo Yun <[email protected]>
Co-authored-by: Jungnerd <[email protected]>
Co-authored-by: Wonhyeong Seo <[email protected]>
Co-authored-by: Nayeon Han <[email protected]>
Co-authored-by: Gabriel Yang <[email protected]>
Co-authored-by: Kihoon Son <[email protected]>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
@sim-so @0525hhgus
@jungnerd @wonhyeongseo @HanNayeoniee @gabrielwithappy @kihoon71 @novice03
🌐 [i18n-KO] Translated tasks/summarization.mdx to Korean (huggingfa…
696bdf4 
…ce#22783)

docs: ko: tasks/summarization.mdx

Co-authored-by: Hyeonseo Yun <[email protected]>
Co-authored-by: Jungnerd <[email protected]>
Co-authored-by: Wonhyeong Seo <[email protected]>
Co-authored-by: Nayeon Han <[email protected]>
Co-authored-by: Gabriel Yang <[email protected]>
Co-authored-by: Kihoon Son <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@wonhyeongseo wonhyeongseo wonhyeongseo requested changes

@0525hhgus 0525hhgus 0525hhgus left review comments

@gabrielwithappy gabrielwithappy gabrielwithappy left review comments

@sgugger sgugger sgugger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@sim-so @HuggingFaceDocBuilderDev @wonhyeongseo @sgugger @0525hhgus @gabrielwithappy