Skip to content

Conversation

@ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Apr 27, 2023

What does this PR do?

Remove the piping with | tee when running pytest.

  1. No one looks at the artifacts, and tee makes the output un-readable, color less etc.
  2. I checked that even if you remove this, the outputs are still visible because Circle CI uses a custom file system handling for this and not the output.txt.
  3. Subtests are omitted from the output this it does not include everything

@ArthurZucker
Copy link
Collaborator Author

@ArthurZucker
Copy link
Collaborator Author

CI outputs without tee:
image (6)
With tee:
image

@ArthurZucker ArthurZucker requested a review from sgugger April 27, 2023 13:29
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@sgugger
Copy link
Collaborator

sgugger commented Apr 27, 2023

No one looks at the artifacts

Speak for yourself ;-) , I only look at artifacts since it's impossible to get the traceback in the output. I do not look at the output artifact however, so that change wouldn't impact how I use the reports. However I'm not alone so make sure @LysandreJik @amyeroberts and @ydshieh all agree before merging this.

@ArthurZucker
Copy link
Collaborator Author

(The full traceback can still be seen!)

@ydshieh
Copy link
Collaborator

ydshieh commented Apr 27, 2023

It seems expanding the run test step is still fast, and personally I don't read test_output.txt but just the reports given by --make_reports, I am OK for this change.

One thing remaining is to remove the upload artifact step if we don't produce it. So far, we get

Uploading /home/circleci/transformers/tests_output.txt to ~/transformers/tests_output.txt
  No artifact files found at /home/circleci/transformers/tests_output.txt
Total size uploaded: 0 B

@amyeroberts
Copy link
Contributor

I use the artefacts all the time :D!

I think it's fine for test_outputs.txt to go though, as I rarely look at it and I think all the other info can be found in the other .txt files 👍

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. If you think this still needs to be addressed please comment on this thread.

Please note that issues that do not follow the contributing guidelines are likely to be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants