Skip to content

Conversation

sim-so
Copy link
Contributor

@sim-so sim-so commented May 28, 2023

What does this PR do?

Translated the pad_truncation.mdx file of the documentation to Korean.
Thank you in advance for your review!

Before reviewing

  • Check for missing / redundant translations (λ²ˆμ—­ λˆ„λ½/쀑볡 검사)
  • Grammar Check (λ§žμΆ€λ²• 검사)
  • Review or Add new terms to glossary (μš©μ–΄ 확인 및 μΆ”κ°€)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview둜 μ •μƒμž‘λ™ 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR?
@0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

May you please review this PR?
@sgugger, @ArthurZucker, @eunseojo

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Contributor

@0525hhgus 0525hhgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쒋은 λ²ˆμ—­ κ°μ‚¬ν•©λ‹ˆλ‹€ πŸ‘
μ˜΅μ…˜μ΄ μ μš©λ˜λŠ” μ‹œν€€μŠ€λ₯Ό λͺ…ν™•νžˆ λ²ˆμ—­ν•΄μ£Όμ…”μ„œ μ‰½κ²Œ 이해할 수 μžˆμ—ˆμŠ΅λ‹ˆλ‹€!
μ•„λž˜ 짧은 리뷰λ₯Ό λ‚¨κΉλ‹ˆλ‹€ πŸ˜€

@HanNayeoniee
Copy link
Contributor

μ—°νœ΄μ— 수고 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€!
μœ„μ—μ„œ λŒ“κΈ€ λ‚¨κ²¨μ£Όμ…”μ„œ 더 μˆ˜μ •ν•  뢀뢄은 μ—†μ–΄ λ³΄μž…λ‹ˆλ‹€!

Copy link
Contributor

@wonhyeongseo wonhyeongseo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ—°νœ΄ 잘 λ³΄λ‚΄μ…¨λ‚˜μš”? 쒋은 λ²ˆμ—­ κ°μ‚¬ν•©λ‹ˆλ‹€!
LGTM!

Co-authored-by: Hyeonseo Yun <[email protected]>
@sim-so
Copy link
Contributor Author

sim-so commented May 31, 2023

Could you review this PR? πŸ˜ƒ
@sgugger, @ArthurZucker, @eunseojo

@sim-so sim-so marked this pull request as ready for review May 31, 2023 08:18
Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this πŸ˜‰

@ArthurZucker ArthurZucker merged commit 015829e into huggingface:main May 31, 2023
@sim-so sim-so deleted the ko-pad-truncation branch June 5, 2023 03:28
gojiteji pushed a commit to gojiteji/transformers that referenced this pull request Jun 5, 2023
)

* docs: ko: pad_truncation.mdx

* feat: manual draft

* fix: resolve suggestions

Co-authored-by: Hyeonseo Yun <[email protected]>

---------

Co-authored-by: Hyeonseo Yun <[email protected]>
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
)

* docs: ko: pad_truncation.mdx

* feat: manual draft

* fix: resolve suggestions

Co-authored-by: Hyeonseo Yun <[email protected]>

---------

Co-authored-by: Hyeonseo Yun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants