Skip to content

Conversation

@mocobeta
Copy link
Contributor

What does this PR do?

This PR fixes AttributeError: 'Trainer' object has no attribute 'local_rank'.
Please see the discussion at #23681 for details.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@mocobeta
Copy link
Contributor Author

This works for me with python 3.10.12 (Google Colab runtime).

@mocobeta mocobeta mentioned this pull request Jun 15, 2023
@amyeroberts
Copy link
Contributor

cc @muellerzr

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Jun 26, 2023

The documentation is not available anymore as the PR was closed or merged.

@sgugger
Copy link
Collaborator

sgugger commented Jun 26, 2023

Friendly ping @muellerzr

Copy link
Contributor

@muellerzr muellerzr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That solution is indeed correct!

@sgugger sgugger merged commit c9fd498 into huggingface:main Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants