Fix number of minimal calls to the Hub with peft integration #25715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
sgugger
commented
Aug 24, 2023
src/transformers/utils/peft_utils.py
Outdated
| raise ValueError("PEFT is not installed. Please install it with `pip install peft`") | ||
|
|
||
| is_peft_version_compatible = version.parse(importlib.metadata.version("peft")) <= version.parse(min_version) | ||
| is_peft_version_compatible = version.parse(importlib.metadata.version("peft")) > version.parse(min_version) |
There was a problem hiding this comment.
This part will be reverted and rebased once #25710 is merged.
| subfolder: str = None, | ||
| token: Optional[str] = None, | ||
| commit_hash: Optional[str] = None, | ||
| cache_dir: Optional[Union[str, os.PathLike]] = None, |
There was a problem hiding this comment.
Add all standard hub kwargs here.
| kwargs["_from_auto"] = True | ||
| kwargs["name_or_path"] = pretrained_model_name_or_path | ||
| trust_remote_code = kwargs.pop("trust_remote_code", None) | ||
| code_revision = kwargs.pop("code_revision", None) |
There was a problem hiding this comment.
Not strictly related to the issue at hand, but this cleanup makes sure code_revision is not recursively passed along.
| kwargs["_from_auto"] = True | ||
| hub_kwargs_names = [ | ||
| "cache_dir", | ||
| "code_revision", |
There was a problem hiding this comment.
This is not strictly a hub kwarg, it's just for the remote code integration.
LysandreJik
approved these changes
Aug 24, 2023
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
…face#25715) * Fix number of minimal calls to the Hub with peft integration * Alternate design * And this way? * Revert * Address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR makes sure we don't add two calls to every model instantiation when PEFT is installed by moving the calls to
find_adapter_config_fileafter the config is created so we can use the commit hash.