Skip to content

Conversation

@sanchit-gandhi
Copy link
Contributor

What does this PR do?

The test test_chunking_and_timestamps failed on the nightly run when checking that the argument return_timestamps=True gave the correct error message for CTC models. This is because the string pattern (char) in the error message was closing the regex expression. Removing it allows the test to pass as expected.

@sanchit-gandhi sanchit-gandhi requested a review from ydshieh August 24, 2023 12:54
Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me. Thanks!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 24, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sanchit-gandhi sanchit-gandhi merged commit 0218876 into huggingface:main Aug 24, 2023
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants