-
Notifications
You must be signed in to change notification settings - Fork 30.9k
[from_pretrained
] Fix failing PEFT tests
#25733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[from_pretrained
] Fix failing PEFT tests
#25733
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ouch I think it's a typo from merging see here
Let's make them not slow otherwise we are shooting in the dark 😉 |
The documentation is not available anymore as the PR was closed or merged. |
We can have a new job to see how long it takes. I would try to keep the new job to run only the PEFT tests but not to re-run the Let's hear our @sgugger 's wisdom too. We will miss it. |
Merging as this is blocking for an upcoming PR #25738 , will address future comments in a follow up PR! |
fix failing PEFT tests
What does this PR do?
Addresses: #25726 (comment)
In fact it is important to overwrite
pretrained_model_name_or_path
with thebase_model_name_or_path
attribute of the adapter config otherwisefrom_pretrained
will try to load the config file from the adapter model_id where it should look for it atbase_model_name_or_path
now all PEFT tests are green
cc @sgugger @ArthurZucker