Skip to content

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented Aug 24, 2023

What does this PR do?

Addresses: #25726 (comment)
In fact it is important to overwrite pretrained_model_name_or_path with the base_model_name_or_path attribute of the adapter config otherwise from_pretrained will try to load the config file from the adapter model_id where it should look for it at base_model_name_or_path

now all PEFT tests are green

cc @sgugger @ArthurZucker

Copy link
Collaborator

@sgugger sgugger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch I think it's a typo from merging see here

@ArthurZucker
Copy link
Collaborator

Let's make them not slow otherwise we are shooting in the dark 😉

@younesbelkada
Copy link
Contributor Author

I agree it sounds important to have it, happy to add a PEFT circleCI job that runs tests_torch as well as PEFT tests, I can do that in a follow up PR, what do you think @sgugger @ydshieh (offline we have agreed to not do it, maybe we should after these failures?)

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 24, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh
Copy link
Collaborator

ydshieh commented Aug 24, 2023

We can have a new job to see how long it takes.

I would try to keep the new job to run only the PEFT tests but not to re-run the tests_torch.

Let's hear our @sgugger 's wisdom too. We will miss it.

@younesbelkada
Copy link
Contributor Author

younesbelkada commented Aug 24, 2023

Merging as this is blocking for an upcoming PR #25738 , will address future comments in a follow up PR!

@younesbelkada younesbelkada merged commit fd0b94f into huggingface:main Aug 24, 2023
@younesbelkada younesbelkada deleted the fix-simplify-oeft branch August 24, 2023 16:48
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants