Skip to content

Conversation

SunMarc
Copy link
Member

@SunMarc SunMarc commented Aug 31, 2023

What does this PR do ?

This PR adds the possibility to change the max input length when using exllama backend + act_order. We also bump the required version of gptq to 0.4.2.
The gptq tests passed and I skipped a test because we need to wait for a release on optimum side.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 31, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@younesbelkada younesbelkada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @SunMarc , thanks a lot! 🔥

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left a few nits on the doc. Could you link / detail what is exllama and act_order?

@SunMarc SunMarc requested a review from ArthurZucker September 5, 2023 13:12
@SunMarc
Copy link
Member Author

SunMarc commented Sep 5, 2023

It works with the new model path :)

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (make sure to rebase on main before merging for the failing tests)

@SunMarc SunMarc merged commit fa6107c into huggingface:main Sep 6, 2023
@SunMarc SunMarc deleted the add_max_input_length branch September 6, 2023 15:45
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* add new arg for gptq

* add tests

* add min version autogptq

* fix order

* skip test

* fix

* Update src/transformers/modeling_utils.py

Co-authored-by: Arthur <[email protected]>

* fix style

* change model path

---------

Co-authored-by: Arthur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants