Skip to content

Conversation

@muellerzr
Copy link
Contributor

What does this PR do?

One potential solution for #25988, we need to guard for things in Accelerate main better for items, especially items like fsdp and deepspeed

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@pacman100

@muellerzr muellerzr requested a review from pacman100 September 5, 2023 13:44
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Sep 5, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello Zach, I think the better way is to handle via version comparison.

@muellerzr
Copy link
Contributor Author

@pacman100 sounds good, let me know if you are pleased :)

@jmif
Copy link
Contributor

jmif commented Sep 6, 2023

Ran into this issue too, confirmed this PR resolves for us.

Copy link
Contributor

@pacman100 pacman100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @muellerzr for iterating!

@pacman100 pacman100 merged commit e3a9716 into main Sep 7, 2023
@pacman100 pacman100 deleted the muellerzr-fix-fsdp branch September 7, 2023 04:22
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
* Fix err

* Use version check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants