[CI] Fix red CI and ERROR failed should show
#25995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArthurZucker
commented
Sep 5, 2023
| steps.append({"run": {"name": "Run tests", "command": test_command}}) | ||
|
|
||
| check_test_command = f'if [ -s reports/tests_{self.name}/failures_short.txt ]; ' | ||
| check_test_command = f'if [ -s reports/{self.job_name}/failures_short.txt ]; ' |
There was a problem hiding this comment.
The test_ is added to self.name in self.job_name based on a rule. self.jon_name is the one that is used when these files are created.
|
The documentation is not available anymore as the PR was closed or merged. |
| self.assertEqual(output, {"text": "A MAN SAID TO THE UNIVERSE SIR I EXIST"}) | ||
|
|
||
| @require_torch | ||
| @slow |
There was a problem hiding this comment.
Looks like this test is not related to the commit that was merged yesterday, which didn't touch this test: 8d51801
This probably failed due to using the whisper-tiny model in the test taking abnormally long, since we've not seen this failure before
Went through all the ASR pipeline tests and they're all correctly marked as slow / not slow now 👍
Merged
parambharat
pushed a commit
to parambharat/transformers
that referenced
this pull request
Sep 26, 2023
* start with error too * fix ? * start with nit * one more path * use `job_name` * mark pipeline test as slow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the main branch after the merge of #25895 which has a typo when checking the outputs of the ci tests.
Two part fix:
should do the trick