Skip to content

Conversation

@wonhyeongseo
Copy link
Contributor

What does this PR do?

@bolizabeth translated the big_models.md file of the documentation to Korean. I made sure hanging suggestions were resolved.
Thank you in advance for your review.

Part of #20179
Moved from #24985

Before reviewing

  • Check for missing / redundant translations (번역 누락/중복 검사)
  • Grammar Check (맞춤법 검사)
  • Review or Add new terms to glossary (용어 확인 및 추가)
  • Check Inline TOC (e.g. [[lowercased-header]])
  • Check live-preview for gotchas (live-preview로 정상작동 확인)

Who can review? (Initial)

Team PseudoLab, may you please review this PR? @0525hhgus, @kihoon71, @sim-so, @gabrielwithappy, @HanNayeoniee, @wonhyeongseo, @jungnerd

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review? (Final)

bolizabeth and others added 4 commits September 19, 2023 15:39
Co-Authored-By: SeongWooChoi <[email protected]>
Co-Authored-By: heuristicwave <[email protected]>
Co-Authored-By: SeongWooChoi <[email protected]>
Co-Authored-By: heuristicwave <[email protected]>
Co-Authored-By: bolizabeth <[email protected]>
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for resolving the final comments!

@stevhliu stevhliu merged commit 7790943 into huggingface:main Oct 12, 2023
@wonhyeongseo wonhyeongseo deleted the ko-big_models_bolizabeth branch October 13, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants