Skip to content

Conversation

ArthurZucker
Copy link
Collaborator

@ArthurZucker ArthurZucker commented Oct 5, 2023

What does this PR do?

Fixes #26605 by making sure the LlamaTokenizerFast handles the cases when bos or eos is None and add_bos_token is set to True by raising an error.

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 5, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Member

@Rocketknight1 Rocketknight1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ArthurZucker!

The failing tests look flaky?

@ArthurZucker
Copy link
Collaborator Author

Yep rebased on main to remove them!

@LysandreJik LysandreJik merged commit 9ad815e into huggingface:main Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot save/load tokenizer without special tokens

4 participants