Skip to content

Conversation

@abzdel
Copy link
Contributor

@abzdel abzdel commented Oct 6, 2023

fixed DonutImageProcessor docstring and removed from OBJECTS_TO_IGNORE in check_docstrings.py

@abzdel
Copy link
Contributor Author

abzdel commented Oct 6, 2023

@ydshieh should be all set! Happy to make changes if needed

@abzdel
Copy link
Contributor Author

abzdel commented Oct 9, 2023

@ydshieh Just fixed this with my most recent commit. Just a heads up - I get the following when I run make fixup. I looked into fixing it but I wasn't quite able to - happy to keep investigating this if needed
image

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 9, 2023

It's probably a TF issue in your environment. Other people also reported this, but I have no clear idea what's going on here as it works for me as well as on CI runner. For this PR, as CI is green, good to merge.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution 🚀 @abzdel ! Very nice.

@ydshieh ydshieh merged commit 3257946 into huggingface:main Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants