-
Notifications
You must be signed in to change notification settings - Fork 31.1k
[docstring] Fix docstring for CodeLlamaTokenizerFast
#26666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docstring] Fix docstring for CodeLlamaTokenizerFast
#26666
Conversation
|
Issues Encountered: System Configuration:
Installation Issue:
Execution Issue:
Next Steps:
|
CodeLlamaTokenizer, CodeLlamaTokenizerFastCodeLlamaTokenizerFast
|
Hi @ydshieh, Doc strings of However, the above dependency issues were a bit confusing and prevented me from updating the doc strings of |
|
cc @ydshieh |
|
Update on issues encountered: |
ydshieh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you for the contribution 🔥 💯 .
I have one question and needs my colleague to confirm.
|
Regarding environment, I am not using Mac, and it seems tensorflow related stuffs are in the way ( Do you have |
I have |
|
Maybe you can remove the 3 places of |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
Let's just merge it. I can create another PR for |
ArthurZucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can open the follow up PR to fix the suffix first issue!
|
Could you resolve the conflicts so that I can approve the pR? 😉 |
I am a bit unsure what you mean by conflict. I have resolved the conversation, if that is what you meant. Please let me know if you would like me to add back the suffix_first parameter. |
|
Check |
Conflict resolved, thank you for the clarification! |
ArthurZucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing 😉
…6666) * remove from OBJECTS_TO_IGNORE * run check_docstrings.py * fill in information * ignore CodeLlamaTokenizer
What does this PR do?
Fixes #26638
Before submitting
Pull Request section?
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.