Skip to content

Conversation

@ydshieh
Copy link
Collaborator

@ydshieh ydshieh commented Oct 12, 2023

What does this PR do?

Skip TrainerIntegrationFSDP::test_basic_run_with_cpu_offload if torch < 2.1 as this takes 4 hours on torch 2.0.

@ydshieh ydshieh requested a review from LysandreJik October 12, 2023 15:39
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 12, 2023

The documentation is not available anymore as the PR was closed or merged.

@ydshieh ydshieh merged commit 3e93dd2 into main Oct 12, 2023
@ydshieh ydshieh deleted the skip_fsdp_cpu_offload_test branch October 12, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants