Skip to content

Conversation

@AaryaBalwadkar
Copy link
Contributor

What does this PR do?

This PR translates the pipeline_tutorial.md in Hindi language and mentions it in _toctree.yml in doc/source/hi/ folder. Thus Fixes # 26787

Before submitting

Who can review?

@stevhliu and @MKhalusova please review this PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@MKhalusova
Copy link
Contributor

Hi @AaryaBalwadkar! Thank you for working on translating the doc page into Hindi.
From what I see, this is the first time a doc page has been translated into Hindi. As such, you'll need to modify two more files in order to build the docs in a new language - .github/workflows/build_documentation.yml and .github/workflows/build_pr_documentation.yml. 


Add the two-letter code for your language to the list of languages. You can look up the code here.

@AaryaBalwadkar
Copy link
Contributor Author

Done the modification in both the files. Please have a look.

Copy link
Contributor

@hakunamatata1997 hakunamatata1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mentioned device=n instead of device=0

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation!

Can you include the changes you made in #26855 in this PR? The doc-builder test on that PR is failing because it can't find the toctree to build the docs.

@AaryaBalwadkar
Copy link
Contributor Author

Ok

@AaryaBalwadkar
Copy link
Contributor Author

Made the changes. Please have a look

@stevhliu
Copy link
Member

Thanks! Can you include the changes you made in #26855 in this PR as well?

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@stevhliu stevhliu merged commit a2f55a6 into huggingface:main Oct 25, 2023
i4never pushed a commit to i4never/transformers that referenced this pull request Oct 26, 2023
* hindi translation of pipeline_tutorial.md

* Update pipeline_tutorial.md

* Update build_documentation.yml

* Update build_pr_documentation.yml

* Updated build_documentation.yml

---------

Co-authored-by: Steven Liu <[email protected]>
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* hindi translation of pipeline_tutorial.md

* Update pipeline_tutorial.md

* Update build_documentation.yml

* Update build_pr_documentation.yml

* Updated build_documentation.yml

---------

Co-authored-by: Steven Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants