Skip to content

Conversation

@jiaqiw09
Copy link
Contributor

What does this PR do?

Part of #26803

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests? not necessary

Who can review?

@stevhliu

@jiaqiw09
Copy link
Contributor Author

Hi @stevhliu

I think it's a very interesting doc, although a little hard to translater as it's more like a introductory article than a technical one. 😀

And I think if more docs are translated, it may attract more people to do some contribution. So just do it !

Besides, I find it's hard to make all subfolders update existed files or non-existed files in time when files in en-folder make some change. Maybe you may have some idea or suggestion. You can just comment this issue #26803 or just make a new issue ! But it's still a work that will need to be taken care of much later. Currently, just do the translation.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 😄 What would you do to make it less like an article?

I think you're on the right track of just translating the current docs first, and then you can update them later as you go or if you notice a change.

@jiaqiw09
Copy link
Contributor Author

@stevhliu

thanks for your review. i just update the file. And for linkS, I just redirect them to files in en folder. and for title, I think it's better to keep transformer_agent untranslated while I just append '教程' to make it more clear.

Besides, to make it more like a article, what I can do now is just try to translate it more clear rather using normal technical way, which just list step1, step2...

Best

Copy link
Member

@stevhliu stevhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

I'll pass your feedback along to the team about the way this doc was written 😄

@stevhliu stevhliu merged commit ef23b68 into huggingface:main Oct 27, 2023
@yyLeaves
Copy link
Contributor

@stevhliu

thanks for your review. i just update the file. And for linkS, I just redirect them to files in en folder. and for title, I think it's better to keep transformer_agent untranslated while I just append '教程' to make it more clear.

Besides, to make it more like a article, what I can do now is just try to translate it more clear rather using normal technical way, which just list step1, step2...

Best

I think the original English title for this tutorial is "Agents" rather than "transformer_agent"

image

@jiaqiw09 jiaqiw09 deleted the transformers_agent branch October 28, 2023 15:10
EduardoPach pushed a commit to EduardoPach/transformers that referenced this pull request Nov 19, 2023
* update translation

* fix problems mentioned in reviews
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants