Correct docstrings and a typo in comments #27047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevhliu
approved these changes
Oct 24, 2023
Member
stevhliu
left a comment
stevhliu
left a comment
There was a problem hiding this comment.
Good catch, thanks for the fixes!
lewis-yeung
commented
Oct 25, 2023
lewis-yeung
changed the title
TrainingArguments.set_* methodsTrainingArguments.set_* methods
Correct docstrings of these methods in `TrainingArguments`: - `set_save` - `set_logging`
Co-authored-by: Steven Liu <[email protected]>
lewis-yeung
changed the title
TrainingArguments.set_* methods
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* docs(training_args): correct docstrings Correct docstrings of these methods in `TrainingArguments`: - `set_save` - `set_logging` * docs(training_args): adjust words in docstrings Co-authored-by: Steven Liu <[email protected]> * docs(trainer): correct a typo in comments --------- Co-authored-by: Steven Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Correct docstrings of the following methods:
TrainingArguments.set_saveTrainingArguments.set_loggingWho can review?
@stevhliu