- 
                Notifications
    You must be signed in to change notification settings 
- Fork 31k
[docstring] Fix docstring for AltCLIPTextConfig, AltCLIPVisionConfig and AltCLIPConfig #27128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docstring] Fix docstring for AltCLIPTextConfig, AltCLIPVisionConfig and AltCLIPConfig #27128
Conversation
…+ cleaned some docstring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding all these fixes!
Just a small comment. Once resolved we're good to merge 🤗
        
          
                utils/check_docstrings.py
              
                Outdated
          
        
      | "AlignTextModel", | ||
| "AlignVisionConfig", | ||
| "AltCLIPTextConfig", | ||
| # "AltCLIPTextConfig", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should just be removed rather than commented out
| # "AltCLIPTextConfig", | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I will remove that. I guess I can do the same for VisionConfig too as they were in the same file.
| Hi @amyeroberts I have made the change. Let me know if anything else is needed from my side. For some reason removing AltCLIPVisionConfig is giving errors so I let it stay there. Any tip on resolving it would be helpful. | 
| @AksharGoyal Thanks! For the removal of the  | 
| @amyeroberts This is what I see when I go to one of the failed workflows  | 
| @AksharGoyal The issue is arising because some of the parameters in  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating!
| The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. | 
…and AltCLIPConfig (huggingface#27128) * [docstring] Fix docstring for AltCLIPVisionConfig, AltCLIPTextConfig + cleaned some docstring * Removed entries from check_docstring.py * Removed entries from check_docstring.py * Removed entry from check_docstring.py * [docstring] Fix docstring for AltCLIPTextConfig, AltCLIPVisionConfig and AltCLIPConfig
What does this PR do?
Fixes #26638
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.