Remove some Kosmos-2 copied from
#27149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Oct 30, 2023
| encoder_states = encoder_states + (hidden_states,) | ||
| if self.gradient_checkpointing and self.training: | ||
| layer_outputs = self.gradient_checkpointing_func( | ||
| layer_outputs = self._gradient_checkpointing_func( |
Collaborator
Author
There was a problem hiding this comment.
This needs to be here to match copied. Follow up is #27149 27148
amyeroberts
approved these changes
Oct 30, 2023
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
And yes - let's move to the new AttentionMaskConverter in a follow-up up :)
|
The documentation is not available anymore as the PR was closed or merged. |
EduardoPach
pushed a commit
to EduardoPach/transformers
that referenced
this pull request
Nov 19, 2023
* fix * fix * fix * fix --------- Co-authored-by: ydshieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Remove some Kosmos-2
copied fromas there is recent change in #27086.Will update them later to match bart, but for now better not to break
mainCI.